Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add nodejs-wheel as a dependency #276

Merged
merged 3 commits into from
May 3, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented May 3, 2024

Pull Request description

This PR adds nodejs-wheel as a dependency. It will help us to ensure that the user will have nodejs locally, so we can use nodejs tools to help us in some tasks (like prettier, for example)

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab xmnlab changed the title fix: Add nodejs-bin as a dependency fix: Add nodejs-wheel as a dependency May 3, 2024
@xmnlab
Copy link
Member Author

xmnlab commented May 3, 2024

@Saransh-cpp @EverVino @Anavelyz @YurelyCamacho , this PR aims to ensure that the user has nodejs locally.
later we can add more auto-formatter tools in the post hook .. so it will keep our lives here easier :)

I need to merge this ASAP, but feel free to add any notes here and I can handle that later.
thanks!

@xmnlab xmnlab merged commit a470d28 into osl-incubator:main May 3, 2024
12 checks passed
@xmnlab xmnlab deleted the add-nodejs-dep branch May 3, 2024 14:54
Copy link

github-actions bot commented May 3, 2024

🎉 This PR is included in version 0.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant